brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikezaccardo <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Add quorum check enricher and agg...
Date Mon, 23 Nov 2015 21:21:34 GMT
Github user mikezaccardo commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1037#discussion_r45662431
  
    --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/Enrichers.java ---
    @@ -891,6 +892,39 @@ protected static int count(Iterable<? extends Object> vals,
boolean includeNullV
             return result;
         }
         
    +    @Beta
    +    public static class ComputingIsQuorate<T extends Object> implements Function<Collection<T>,
T> {
    --- End diff --
    
    Changing this definition to `public static class ComputingIsQuorate implements Function<Collection<Boolean>,
Boolean>` is certainly sensible.
    
    However, doing this causes problems in `Aggregator`.  The return value must ultimately
be assigned to `Function<? super Collection<T>, ? extends U> transformation` but
I cannot seem to escape compile errors when attempting to cast / assign the value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message