brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Add quorum check enricher and agg...
Date Mon, 23 Nov 2015 17:17:26 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1037#discussion_r45631366
  
    --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/Aggregator.java ---
    @@ -64,6 +65,10 @@
         
         public static final ConfigKey<Boolean> EXCLUDE_BLANK = ConfigKeys.newBooleanConfigKey("enricher.aggregator.excludeBlank",
"Whether explicit nulls or blank strings should be excluded (default false); this only applies
if no value filter set", false);
     
    +    public static final ConfigKey<String> QUORUM_CHECK_TYPE = ConfigKeys.newStringConfigKey("quorum.check.type",
"The requirement to be considered quorate", "allAndAtLeastOne");
    --- End diff --
    
    Worth indicating the possible values in the description? Appreciate there's a chance it
could get out of sync with the strings in QuorumCheck.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message