brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Adds support for interfaces tag o...
Date Fri, 20 Nov 2015 18:34:51 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1039#discussion_r45501515
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/BrooklynTags.java ---
    @@ -51,9 +53,42 @@ public String getContents() {
                 return contents;
             }
         }
    +
    +    public static class InterfacesTag {
    +        @JsonProperty
    +        final List<Class<?>> interfaces;
    --- End diff --
    
    Have you looked at the persistence files, how are classes serialized? Could be leaking
a lot of state. Does it rebind cleanly if classes are coming from osgi bundles?
    Consider converting to strings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message