brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tbouron <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Adds support for interfaces tag o...
Date Thu, 19 Nov 2015 16:32:44 GMT
Github user tbouron commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1039#issuecomment-158110422
  
    Ok, I have an idea that might suit everyone. We keep the newly introduced `referenceType`
in the `CatalogItem` and we populate it with the fully qualified class name or the catalog
item ID (same as what this PR do currently). For every catalog item, we still add the `InterfacesTags`
**but only** if the `referenceType` is a fully qualified class name.
    
    Now, we modify the `CatalogTransfomer` to get all underlying interfaces if the current
item has a reference to another catalog item, and so on. Like that, we keep the best of both
worlds:
    - Interfaces are stored upon catalog item addition.
    - REST API returns a consolidated list of all interfaces, build at runtime.
    
    WDYT @neykov @sjcorbett @nakomis ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message