brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Adds support for interfaces tag o...
Date Wed, 18 Nov 2015 19:31:40 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1039#discussion_r45247705
  
    --- Diff: usage/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogItemSummary.java
---
    @@ -140,7 +166,7 @@ public String toString() {
     
         @Override
         public int hashCode() {
    -        return Objects.hashCode(symbolicName, version, name, javaType, deprecated);
    +        return Objects.hashCode(symbolicName, version, name, javaType, tags, deprecated);
    --- End diff --
    
    Ah, I see where EqualsBuilder came from. I guess when a class uses `EqualsBuilder` we
should also use `HashCodeBuilder`. (Or, in my preference, not use `EqualsBuilder`!) This class
disobeys the equals/hashcode contract. Not your fault, of course. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message