brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Adds support for interfaces tag o...
Date Wed, 18 Nov 2015 19:26:31 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1039#discussion_r45246870
  
    --- Diff: usage/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogItemSummary.java
---
    @@ -121,6 +132,20 @@ public String getIconUrl() {
             return iconUrl;
         }
     
    +    public Collection<Object> getTags() {
    +        List<Object> result = new ArrayList<Object>();
    +        for (Object t : tags) {
    +            // TODO if we had access to a mapper we could use it to give better json
    --- End diff --
    
    Can you expand on your comment? It's not really the job of a summary class to configure
mappers but technically it does have access to one. Should you be adding another class to
`org.apache.brooklyn.rest.transform`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message