brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Flesh out type creation using the...
Date Tue, 17 Nov 2015 17:40:10 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r45091965
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/typereg/RegisteredType.java ---
    @@ -38,19 +46,24 @@
         String getDescription();
         String getIconUrl();
     
    -    /** @return the java type or a supertype thereof that this registered type represents.
    +    /** @return all declared supertypes or super-interfaces of this registered type,
    +     * consisting of a collection of {@link Class} or {@link RegisteredType}
          * <p>
    -     * For beans, this is the type that the {@link BrooklynTypeRegistry} will create.

    -     * For specs, this is what the spec that will be created points at 
    -     * (e.g. the concrete {@link Entity}, not the {@link EntitySpec});
    +     * This should normally include at least one {@link Class} object:
    +     * For beans, this should include the java type that the {@link BrooklynTypeRegistry}
will create. 
    +     * For specs, this should refer to the {@link BrooklynObject} type that the created
spec will point at 
    +     * (e.g. the concrete {@link Entity}, not the {@link EntitySpec}).
          * <p>
    -     * In some cases this may return an interface or a super-type of what will actually
be created, 
    +     * This may not necessarily return the most specific java class or classes;
          * such as if the concrete type is private and callers should know only about a particular
public interface,
          * or if precise type details are unavailable and all that is known at creation is
some higher level interface/supertype
          * (e.g. this may return {@link Entity} even though the spec points at a specific
subclass,
    -     * for instance because the YAML has not yet been parsed or OSGi bundles downloaded).

    +     * for instance because the YAML has not yet been parsed or OSGi bundles downloaded).
    +     * <p>
    +     * This may include other registered types such as marker interfaces.
          */
    -    Class<?> getJavaType();
    +    @Beta
    +    @Nullable Set<Object> getSuperTypes();
    --- End diff --
    
    shouldn't be, will remove


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message