brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix jclouds sshable
Date Tue, 17 Nov 2015 12:04:34 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1034#discussion_r45051833
  
    --- Diff: utils/common/src/main/java/org/apache/brooklyn/util/net/Networking.java ---
    @@ -486,6 +487,12 @@ public static boolean isLocalhost(String remoteAddress) {
         }
         
         public static boolean isReachable(HostAndPort endpoint) {
    +        // TODO Should we create an unconnected socket, and then use the calls below
(see jclouds' InetSocketAddressConnect):
    +        //      socket.setReuseAddress(false);
    +        //      socket.setSoLinger(false, 1);
    +        //      socket.setSoTimeout(timeout);
    +        //      socket.connect(socketAddress, timeout);
    --- End diff --
    
    Don't see the point of the above, but +1 for the `,conntect` timeout.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message