brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Flesh out type creation using the...
Date Tue, 17 Nov 2015 11:39:10 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r45049790
  
    --- Diff: usage/camp/src/main/java/org/apache/brooklyn/camp/brooklyn/api/AssemblyTemplateSpecInstantiator.java
---
    @@ -23,19 +23,23 @@
     
     import org.apache.brooklyn.api.entity.Application;
     import org.apache.brooklyn.api.entity.EntitySpec;
    +import org.apache.brooklyn.api.mgmt.classloading.BrooklynClassLoadingContext;
     import org.apache.brooklyn.camp.CampPlatform;
     import org.apache.brooklyn.camp.spi.AssemblyTemplate;
     import org.apache.brooklyn.camp.spi.instantiate.AssemblyTemplateInstantiator;
    -import org.apache.brooklyn.core.mgmt.classloading.BrooklynClassLoadingContext;
     
     public interface AssemblyTemplateSpecInstantiator extends AssemblyTemplateInstantiator
{
     
    +    @Deprecated /** @deprecaed since 0.9.0 include encountered types */
    +    EntitySpec<? extends Application> createApplicationSpec(AssemblyTemplate template,
CampPlatform platform, BrooklynClassLoadingContext loader);
    +    
         /**
          * Gets the single item returned by {@link #createServiceSpecs}
          * and wraps it in an Application if needed, applying top-level
          * attributes and locations to the root entity.
          */
    -    EntitySpec<? extends Application> createApplicationSpec(AssemblyTemplate template,
CampPlatform platform, BrooklynClassLoadingContext loader);
    +    EntitySpec<? extends Application> createApplicationSpec(AssemblyTemplate template,
CampPlatform platform, BrooklynClassLoadingContext loader, Set<String> encounteredCatalogTypes);
    --- End diff --
    
    agree, but the `CampResolver` methods use it, currently calling to this when they should
be calilng services.  rather than repair that i hope we can deprecate all of this in favour
of a new much simpler `CampTypePlanTransformer`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message