brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Flesh out type creation using the...
Date Tue, 17 Nov 2015 11:29:08 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r45048982
  
    --- Diff: core/src/test/java/org/apache/brooklyn/core/catalog/internal/SpecParameterInMetaTest.java
---
    @@ -43,18 +49,40 @@
     public class SpecParameterInMetaTest {
         private ManagementContext mgmt;
         private BrooklynCatalog catalog;
    -    private String spec;
    +    private String specId;
     
         @BeforeMethod(alwaysRun=true)
         public void setUp() {
             mgmt = LocalManagementContextForTests.newInstanceWithOsgi();
             catalog = mgmt.getCatalog();
    -        spec = TestToSpecTransformer.registerSpec(EntitySpec.create(BasicEntity.class));
    +        StaticTypePlanTransformer.forceInstall();
    +        PlanToSpecFactory.forceAvailable(TestToSpecTransformer.class, JavaCatalogToSpecTransformer.class);
    --- End diff --
    
    Intention is to get rid of the `TestToSpecTransformer` but we need a bit more machinery
first.  Have added TODO to that effect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message