brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Flesh out type creation using the...
Date Tue, 17 Nov 2015 11:18:23 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r45048101
  
    --- Diff: core/src/test/java/org/apache/brooklyn/core/catalog/internal/StaticTypePlanTransformer.java
---
    @@ -0,0 +1,115 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.core.catalog.internal;
    +
    +import java.util.List;
    +import java.util.Map;
    +import java.util.concurrent.ConcurrentHashMap;
    +
    +import org.apache.brooklyn.api.internal.AbstractBrooklynObjectSpec;
    +import org.apache.brooklyn.api.typereg.RegisteredType;
    +import org.apache.brooklyn.api.typereg.RegisteredTypeLoadingContext;
    +import org.apache.brooklyn.core.typereg.AbstractTypePlanTransformer;
    +import org.apache.brooklyn.core.typereg.JavaClassNameTypePlanTransformer;
    +import org.apache.brooklyn.core.typereg.TypePlanTransformers;
    +import org.apache.brooklyn.util.text.Identifiers;
    +
    +/**
    + * Resolves previously registered specs by id.
    + * First create a spec and register it, keeping the returned ID:
    + * <pre> {@code
    + * String specId = StaticTypePlanTransformer.registerSpec(EntitySpec.create(BasicEntity.class));
    + * }</pre>
    + *
    + * Then build a plan to be resolved such as:
    + * <pre> {@code
    + *  brooklyn.catalog:
    + *    id: test.inputs
    + *    version: 0.0.1
    + *    item: <specId>
    + * } </pre>
    + */
    +public class StaticTypePlanTransformer extends AbstractTypePlanTransformer {
    +    
    +    public StaticTypePlanTransformer() {
    +        super("static-types", "Static Type", "Static transformer for use in tests");
    +    }
    +
    +    private static final Map<String, AbstractBrooklynObjectSpec<?, ?>> REGISTERED_SPECS
= new ConcurrentHashMap<>();
    +
    +    public static void forceInstall() {
    +        TypePlanTransformers.forceAvailable(StaticTypePlanTransformer.class, JavaClassNameTypePlanTransformer.class);
    --- End diff --
    
    different.  this one requires the caller to provide the specs.  `JCNTPT` does a `Class.forName(typeName)`
to create the spec.  added javadoc to this effect, plus a few other cleanups (clears the `REGISTERED_SPECS`
map!)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message