brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-193: Add configuration f...
Date Tue, 17 Nov 2015 11:15:34 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1033#discussion_r45047799
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindManagerImpl.java
---
    @@ -92,6 +92,9 @@
         public static final ConfigKey<RebindFailureMode> REBIND_FAILURE_MODE =
                 ConfigKeys.newConfigKey(RebindFailureMode.class, "rebind.failureMode.rebind",
                         "Action to take if a failure occurs during rebind", RebindFailureMode.FAIL_AT_END);
    +    public static final ConfigKey<RebindFailureMode> ADD_CONFIG_FAILURE_MODE =
    +            ConfigKeys.newConfigKey(RebindFailureMode.class, "rebind.failureMode.addConfig",
    +                    "Action to take if a failure occurs when setting a config value.
It could happen coercion of the value type to fail.", RebindFailureMode.FAIL_AT_END);
    --- End diff --
    
    As long as we can definitely supply the configuration on Brooklyn startup to override
it to CONTINUE, so that a customer can rebind with this kind of error.
    
    @bostko can we definitely do that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message