brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Flesh out type creation using the...
Date Tue, 17 Nov 2015 10:07:16 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r45041185
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/plan/PlanToSpecFactory.java ---
    @@ -36,12 +40,30 @@
     import com.google.common.base.Function;
     import com.google.common.collect.ImmutableList;
     
    +/** @deprecated since 0.9.0 use {@link TypePlanTransformers} as part of switch to {@link
BrooklynTypePlanTransformer};
    + * mark transformers as deprecated if there is a preferred corresponding {@link BrooklynTypePlanTransformer}
*/
    +@Deprecated 
     public class PlanToSpecFactory {
         
         private static final Logger log = LoggerFactory.getLogger(PlanToSpecFactory.class);
     
    -    private static Collection<PlanToSpecTransformer> getAll() {
    -        return ImmutableList.copyOf(ServiceLoader.load(PlanToSpecTransformer.class));
    +    private static Collection<PlanToSpecTransformer> getAll(boolean includeDeprecated)
{
    --- End diff --
    
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message