brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Flesh out type creation using the...
Date Tue, 17 Nov 2015 09:55:24 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r45040042
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/internal/AbstractBrooklynObjectSpec.java
---
    @@ -160,5 +172,9 @@ public boolean equals(Object obj) {
         public int hashCode() {
             return Objects.hashCode(getCatalogItemId(), getDisplayName(), getType(), getTags());
         }
    +
    +    /** strings inserted as flags, config keys inserted as config keys; 
    +     * if you want to force one or the other, create a ConfigBag and convert to the appropriate
map type */
    +    public abstract SpecT configure(Map<?,?> val);
    --- End diff --
    
    you're right, that simplifies things -- have promoted all flag/config methods, and done
related tidy


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message