brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: BROOKLYN-193: Add configuration f...
Date Mon, 16 Nov 2015 13:24:41 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1033#discussion_r44922056
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindManagerImpl.java
---
    @@ -92,6 +92,9 @@
         public static final ConfigKey<RebindFailureMode> REBIND_FAILURE_MODE =
                 ConfigKeys.newConfigKey(RebindFailureMode.class, "rebind.failureMode.rebind",
                         "Action to take if a failure occurs during rebind", RebindFailureMode.FAIL_AT_END);
    +    public static final ConfigKey<RebindFailureMode> ADD_CONFIG_FAILURE_MODE =
    +            ConfigKeys.newConfigKey(RebindFailureMode.class, "rebind.failureMode.addConfig",
    +                    "Action to take if a failure occurs when setting a config value.
It could happen coercion of the value type to fail.", RebindFailureMode.FAIL_AT_END);
    --- End diff --
    
    Good point, keep it as is. I confused it for a different functionality (`--startupFailOnPersistenceErrors`
startup option).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message