brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Restore old HttpTool / Response f...
Date Fri, 13 Nov 2015 21:09:28 GMT
Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1032#issuecomment-156557447
  
    Did some more testing, unfortunately this doesn't fully solve the problem. Will hold off
merging so we can further discuss it. The changes here are perfectly good though, but not
enough.
    
    There's an API that's heavilty used in entities - `HttpFeed` and related (i.e. `HttpValueFunction`,
`HttpPollConfig`). The package renaming changes the signature of the methods in these classes
so that already compiled entities against pre-changes version will not be compatible with
post-changes versions. Probably worth moving to the dev list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message