brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Flesh out type creation using the...
Date Thu, 12 Nov 2015 13:10:07 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r44654463
  
    --- Diff: usage/camp/src/main/java/org/apache/brooklyn/camp/brooklyn/api/AssemblyTemplateSpecInstantiator.java
---
    @@ -23,19 +23,23 @@
     
     import org.apache.brooklyn.api.entity.Application;
     import org.apache.brooklyn.api.entity.EntitySpec;
    +import org.apache.brooklyn.api.mgmt.classloading.BrooklynClassLoadingContext;
     import org.apache.brooklyn.camp.CampPlatform;
     import org.apache.brooklyn.camp.spi.AssemblyTemplate;
     import org.apache.brooklyn.camp.spi.instantiate.AssemblyTemplateInstantiator;
    -import org.apache.brooklyn.core.mgmt.classloading.BrooklynClassLoadingContext;
     
     public interface AssemblyTemplateSpecInstantiator extends AssemblyTemplateInstantiator
{
     
    +    @Deprecated /** @deprecaed since 0.9.0 include encountered types */
    +    EntitySpec<? extends Application> createApplicationSpec(AssemblyTemplate template,
CampPlatform platform, BrooklynClassLoadingContext loader);
    --- End diff --
    
    No point in keeping this method. There will be compile errors anyway because of the new
one and it doesn't even get called (false sense of security).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message