brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Flesh out type creation using the...
Date Thu, 12 Nov 2015 10:26:00 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1017#discussion_r44641309
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/typereg/RegisteredTypePredicates.java
---
    @@ -109,36 +109,46 @@ public boolean apply(@Nullable RegisteredType item) {
             }
         }
     
    -    public static <T> Predicate<RegisteredType> javaType(final Predicate<Class<T>>
filter) {
    -        return new JavaTypeMatches(filter);
    +    public static <T> Predicate<RegisteredType> anySuperType(final Predicate<Class<T>>
filter) {
    +        return new AnySuperTypeMatches(filter);
         }
         @SuppressWarnings({ "unchecked", "rawtypes" })
    -    public static Predicate<RegisteredType> javaTypeAssignableFrom(final Class<?>
filter) {
    -        return javaType((Predicate)Predicates.assignableFrom(filter));
    +    public static Predicate<RegisteredType> assignableFrom(final Class<?>
filter) {
    +        return anySuperType((Predicate)Predicates.assignableFrom(filter));
         }
         
    -    private static class JavaTypeMatches implements Predicate<RegisteredType> {
    +    private static class AnySuperTypeMatches implements Predicate<RegisteredType>
{
             private final Predicate<Class<?>> filter;
             
             @SuppressWarnings({ "rawtypes", "unchecked" })
    -        private <T> JavaTypeMatches(Predicate filter) {
    +        private <T> AnySuperTypeMatches(Predicate filter) {
    --- End diff --
    
    Generic type not used, remove.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message