brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Implementation of proposed Test E...
Date Wed, 11 Nov 2015 09:33:47 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/999#discussion_r44515191
  
    --- Diff: usage/test-framework/src/main/java/org/apache/brooklyn/test/framework/TestHttpCall.java
---
    @@ -0,0 +1,33 @@
    +package org.apache.brooklyn.test.framework;
    +
    +import com.google.common.collect.Maps;
    +import org.apache.brooklyn.api.entity.Entity;
    +import org.apache.brooklyn.api.entity.ImplementedBy;
    +import org.apache.brooklyn.config.ConfigKey;
    +import org.apache.brooklyn.core.config.ConfigKeys;
    +import org.apache.brooklyn.core.entity.trait.Startable;
    +import org.apache.brooklyn.util.core.flags.SetFromFlag;
    +import org.apache.brooklyn.util.time.Duration;
    +
    +import java.util.Map;
    +import java.util.concurrent.TimeUnit;
    +
    +/**
    + * Entity that makes a HTTP Request and tests the respose
    + *
    + * @author johnmccabe
    + */
    +@ImplementedBy(value = TestHttpCallImpl.class)
    +public interface TestHttpCall extends Entity, Startable {
    --- End diff --
    
    feels odd that `EffectorTest` extends `BaseTest` but this has no such marker; some sort
of marker would be useful here -- especially if it can inherit `ASSERTIONS` and `TIMEOUT`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message