brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Add ManagementContext.getConfigWi...
Date Wed, 11 Nov 2015 07:43:02 GMT
Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1018#issuecomment-155694726
  
    The changes look good. I like the approach because there's no hidden magic, easy to reason
about. On the other hand what I don't like is that it would be very hard to figure out which
config keys support external config, leaving users confused.
    
    What problems surfaced when you tried resolving the values when requested (what you mention
in the description)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message