brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bostko <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: SshTool choice
Date Tue, 10 Nov 2015 10:10:42 GMT
Github user bostko commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1013#discussion_r44389092
  
    --- Diff: core/src/main/java/org/apache/brooklyn/util/core/internal/ssh/SshTool.java ---
    @@ -49,7 +50,14 @@
          * These keys are detected from entity/global config and automatically applied to
ssh executions. */
         public static final String BROOKLYN_CONFIG_KEY_PREFIX = "brooklyn.ssh.config.";
         
    -    public static final ConfigKey<String> PROP_TOOL_CLASS = newStringConfigKey("tool.class",
"SshTool implementation to use", null);
    +    /**
    +     * @deprecated since 0.9.0; use {@link SshMachineLocation#SSH_TOOL_CLASS}
    +     */
    +    @Deprecated
    +    public static final ConfigKey<String> PROP_TOOL_CLASS = newStringConfigKey(
    --- End diff --
    
    Can you explain why did you deprecate this?
    It is good if this key is in a generic location like `SshTool`. I was thinking about refactoring
Winrm support to follow the same pattern as it is for ssh, if so we could implement this dynamic
sshTool loading with the same keys and the same API.
    In regard with this please check https://github.com/apache/incubator-brooklyn/pull/950


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message