brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Prevent catalog recursion in $bro...
Date Mon, 09 Nov 2015 13:16:14 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1010#discussion_r44272897
  
    --- Diff: usage/camp/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/CatalogYamlAppTest.java
---
    @@ -24,50 +24,32 @@
     
     
     public class CatalogYamlAppTest extends AbstractYamlTest {
    -    
    -    /**
    -     * "Contrived" example was encountered by a customer in a real use-case!
    -     * I couldn't yet simplify it further while still reproducing the failure.
    -     * Throws StackOverlfowError, without giving a nice error message about 
    -     * "BasicEntity" cyclic reference.
    -     * 
    -     * The circular reference comes from the member spec referencing 
    -     * "org.apache.brooklyn.entity.stock.BasicEntity", but that has been defined in the
    -     * catalog as this new blueprint (which overrides the previous value of it
    -     * being a reference to the Java class).
    -     * 
    -     * We need to use an id that matches something else already on the classpath.
    -     * Otherwise we'd get an error telling us "could not resolve item ..." when
    -     * attempting to add the initial catalog item.
    -     */
    -    @Test(groups="WIP") // TODO Fix this!
    -    public void testAddCatalogItemWithCircularReference() throws Exception {
    -        // Add a catalog item with a circular reference to its own id.
    +
    +    @Test
    +    public void testAddCatalogItemWithMemberSpecCircularReference() throws Exception
{
    --- End diff --
    
    test addition is good, but is it worth keeping the note/sketch-test for the case where
the circular reference is in a child?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message