brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: YAML config keys (parameters)
Date Thu, 05 Nov 2015 15:27:12 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1001#issuecomment-154093232
  
    Oh I understand the question now -- should `RegisteredType` expose a `getDefinedConfigKeys()`.
 That functionality is wanted for specs to show detail in the catalog.  However I think we
can get that simply by the caller creating the spec and then asking the spec -- so still I'd
say no.
    
    Have looked over the code briefly and it looks good, nay, great.
    
    The test failure looks unrelated to this PR; seems related to @geomacy's recent addition:
    
        shouldAssertContentEventuallyMatchesWithFlags(org.apache.brooklyn.util.HttpAssertsTest)
        java.lang.AssertionError: Assertion failed
    	at java.net.PlainSocketImpl.socketConnect(Native Method)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message