brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geomacy <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Add EntityAsserts and HttpUtils.
Date Thu, 05 Nov 2015 14:27:31 GMT
Github user geomacy commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/994#issuecomment-154074295
  
    The sleeps are there to allow the test HTTP server time to shut down.  That's not required
in all tests, so I could speed things up a bit by changing the test condition, but it is needed
in some cases (for the 'eventually becomes unavailable' type tests).  I could add a timeout
to the shutdown, but it occurs to me that it might be better to mark these as integration
tests, because
    
    - (a) they are not going to run any faster (they already take , and 
    - (b) the code under test is fairly 'low level' and not likely to break because of other
code within Brooklyn changing
    
    so it may not add a lot of value to run these tests on every build, and it will slow things
down a bit. 
    
    What do you think?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message