brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: HTTP connection pooling for Brook...
Date Wed, 04 Nov 2015 17:11:52 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1000#discussion_r43908770
  
    --- Diff: usage/rest-client/src/main/java/org/apache/brooklyn/rest/client/BrooklynApi.java
---
    @@ -114,11 +150,23 @@ public BrooklynApi(String endpoint, @Nullable Credentials credentials)
{
             }
         }
     
    +    /**
    +     * @deprecated since 0.9.0. Use {@link BrooklynApiFactory#getBrooklynApi(java.net.URL,
String, String)} instead
    +     * @see org.apache.brooklyn.rest.client.DefaultBrooklynApiFactory
    +     * @see org.apache.brooklyn.rest.client.PoolingBrooklynApiFactory
    +     */
    +    @Deprecated
    --- End diff --
    
    Sounds a bit too involved just to construct the object. When in doubt I try to follow
the "Keep it simple" moto. Nothing wrong with using it without a factory. The factory just
does some sugaring over the parameters.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message