brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From googlielmo <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: HTTP connection pooling for Brook...
Date Wed, 04 Nov 2015 16:56:38 GMT
Github user googlielmo commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1000#discussion_r43906767
  
    --- Diff: usage/rest-client/src/main/java/org/apache/brooklyn/rest/client/BrooklynApi.java
---
    @@ -114,11 +150,23 @@ public BrooklynApi(String endpoint, @Nullable Credentials credentials)
{
             }
         }
     
    +    /**
    +     * @deprecated since 0.9.0. Use {@link BrooklynApiFactory#getBrooklynApi(java.net.URL,
String, String)} instead
    +     * @see org.apache.brooklyn.rest.client.DefaultBrooklynApiFactory
    +     * @see org.apache.brooklyn.rest.client.PoolingBrooklynApiFactory
    +     */
    +    @Deprecated
    --- End diff --
    
    Yup, it's a little too protective there. What if we change to `protected` and let the
user subclass the `BrooklynApi` to provide an alternative implementation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message