brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: [BROOKLYN-190] Move from Jetty8 t...
Date Wed, 04 Nov 2015 11:09:18 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/997#discussion_r43867603
  
    --- Diff: usage/launcher/src/test/java/org/apache/brooklyn/launcher/BrooklynWebServerTest.java
---
    @@ -146,11 +146,13 @@ public void verifyHttpsFromConfig() throws Exception {
         @Test
         public void verifyHttpsCiphers() throws Exception {
             brooklynProperties.put(BrooklynWebConfig.HTTPS_REQUIRED, true);
    -        brooklynProperties.put(BrooklynWebConfig.TRANSPORT_PROTOCOLS, "XXX");
    -        brooklynProperties.put(BrooklynWebConfig.TRANSPORT_CIPHERS, "XXX");
    --- End diff --
    
    The point of the test is to check whether the server actually uses the configured ciphers,
protocols. So non-existing ciphers are configured which should cause the handshake to fail.
    The exception is coming from the client, connecting to jetty. It should be independent
of the jetty version as this is at the ssl connection level which is handled by the JVM.
    On my system the root cause is `Caused by: java.io.EOFException: SSL peer shut down incorrectly`
because the server can't match the ciphers offered by the client and immediately closes the
connection.
    So keep the properties and if needed adjust the test to assert the correct exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message