brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Add EntityAsserts and HttpUtils.
Date Tue, 03 Nov 2015 20:40:07 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/994#discussion_r43803617
  
    --- Diff: usage/test-support/src/main/java/org/apache/brooklyn/test/EntityTestUtils.java
---
    @@ -46,20 +45,25 @@
     import com.google.common.collect.Maps;
     import com.google.common.collect.Sets;
     
    +/**
    + * A utility class containing tests on Entities.
    + *
    + * @deprecated Prefer core assertions class org.apache.brooklyn.core.entity.EntityAsserts.
    --- End diff --
    
    Can you include a "since 0.9.0" in the deprecated javadoc line. Same for anywhere else
you've added `@deprecated`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message