brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Introduce a type registry as a si...
Date Mon, 02 Nov 2015 15:22:06 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/993#discussion_r43638771
  
    --- Diff: usage/camp/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/CatalogYamlRebindTest.java
---
    @@ -198,13 +191,7 @@ protected void runRebindWithCatalogAndApp(RebindWithCatalogTestMode
mode) throws
                     addCatalogItems(String.format(locCatalogFormat, locVersion));
                     break;
                 case STRIP_DEPRECATION_AND_ENABLEMENT_FROM_CATALOG_ITEM:
    -                //Make sure that the flags are actually removed from the XML instead
of still being there with false values
    -                appItem.setDeprecated(true);
    -                appItem.setDisabled(true);
    -                mgmt().getCatalog().persist(appItem);
    -                locItem.setDisabled(true);
    -                locItem.setDeprecated(true);
    -                mgmt().getCatalog().persist(locItem);
    +                // nothing here -- but below we rebind with these fields removed to ensure
that we can rebind
    --- End diff --
    
    Have restored them, but it looks like the following code removes those entries whether
they are true or false so curious why it is necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message