brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <>
Subject [GitHub] incubator-brooklyn pull request: Introduce a type registry as a si...
Date Mon, 02 Nov 2015 15:16:46 GMT
Github user ahgittin commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/brooklyn/core/resolve/ ---
    @@ -21,18 +21,18 @@
     import java.util.Map;
     import java.util.Set;
    -import org.apache.brooklyn.api.catalog.CatalogItem;
    -import org.apache.brooklyn.api.catalog.CatalogItem.CatalogItemType;
     import org.apache.brooklyn.api.location.Location;
     import org.apache.brooklyn.api.location.LocationSpec;
     import org.apache.brooklyn.api.policy.Policy;
     import org.apache.brooklyn.api.policy.PolicySpec;
    -import org.apache.brooklyn.core.catalog.internal.CatalogUtils;
    -import org.apache.brooklyn.core.mgmt.EntityManagementUtils;
    +import org.apache.brooklyn.api.typereg.RegisteredType;
     import org.apache.brooklyn.core.mgmt.classloading.BrooklynClassLoadingContext;
     import org.apache.brooklyn.core.objs.BrooklynObjectInternal.ConfigurationSupportInternal;
     import org.apache.brooklyn.util.guava.Maybe;
    +@Deprecated /** @deprecated since 0.9.0 never belonged here, and not used much; new principled
TypeRegistry simplifies things */
    --- End diff --
    k.  it's a good idea but i think `TypeRegistry` gives us a cleaner place to (as soon as
we can) move this logic

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message