Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CDB5618AB5 for ; Tue, 27 Oct 2015 16:36:45 +0000 (UTC) Received: (qmail 18224 invoked by uid 500); 27 Oct 2015 16:36:45 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 18189 invoked by uid 500); 27 Oct 2015 16:36:45 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 18178 invoked by uid 99); 27 Oct 2015 16:36:45 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2015 16:36:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0BF4A1A0AF5 for ; Tue, 27 Oct 2015 16:36:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.991 X-Spam-Level: X-Spam-Status: No, score=0.991 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id MzlSqCRTwglZ for ; Tue, 27 Oct 2015 16:36:32 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 296ED20924 for ; Tue, 27 Oct 2015 16:36:31 +0000 (UTC) Received: (qmail 18130 invoked by uid 99); 27 Oct 2015 16:36:30 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Oct 2015 16:36:30 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E9B9CDFE13; Tue, 27 Oct 2015 16:36:29 +0000 (UTC) From: neykov To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: Update Tomcat's webapp.url sensor... Content-Type: text/plain Message-Id: <20151027163629.E9B9CDFE13@git1-us-west.apache.org> Date: Tue, 27 Oct 2015 16:36:29 +0000 (UTC) Github user neykov commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/959#issuecomment-151561676 Don't fully agree @ahgittin, `main.uri` should be the externally accessible URL, where sensors will poll for values, will be given to users to connect to. Whether you need an external or internal url *between* entities is known at composition time only. If doing it in yaml you'll want to override the default sensor. Java group entities usually assume local network and directly use the subnet sensor (see [this](https://github.com/apache/incubator-brooklyn/blob/master/software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/riak/RiakClusterImpl.java#L231-L232) for example). So until we have a principled way to handle this I'd say keep the public IP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---