Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-963-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-963-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: BROOKLYN-184: auto-manage
 entitie...
Content-Type: text/plain
Message-Id: <20151015195828.CC911E10F9@git1-us-west.apache.org>
Date: Thu, 15 Oct 2015 19:58:28 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/963#discussion_r42172332
  
    --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/Enrichers.java ---
    @@ -520,6 +522,10 @@ public B from(Entity val) {
                 this.fromEntity = checkNotNull(val);
                 return self();
             }
    +        public B from(Task<? extends Entity> val) {
    --- End diff --
    
    Note that I added in this PR the seemingly unrelated "Enrichers: support producer as Task for deferred supplier" so that I could re-write some of the code to use `EntitySpec`, rather than the previous way of constructing two entities and then calling `manage()`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---