Return-Path: 
 <dev-return-10547-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 0CDFD18C0F
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Mon,  5 Oct 2015 13:57:41 +0000 (UTC)
Received: (qmail 6135 invoked by uid 500); 5 Oct 2015 13:57:41 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 6101 invoked by uid 500); 5 Oct 2015 13:57:40 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 6090 invoked by uid 99); 5 Oct 2015 13:57:40 -0000
Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Oct 2015 13:57:40 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org)
 with ESMTP id B700AC29F5
	for <dev@brooklyn.apache.org>; Mon,  5 Oct 2015 13:57:39 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.971
X-Spam-Level: 
X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-eu-west.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new,
 port 10024)
	with ESMTP id UQRJmeXNhc8U for <dev@brooklyn.apache.org>;
	Mon,  5 Oct 2015 13:57:30 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with
 SMTP id B4764201F9
	for <dev@brooklyn.incubator.apache.org>;
 Mon,  5 Oct 2015 13:57:29 +0000 (UTC)
Received: (qmail 5511 invoked by uid 99); 5 Oct 2015 13:57:28 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Oct 2015 13:57:28 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 8983EE0441; Mon,  5 Oct 2015 13:57:28 +0000 (UTC)
From: neykov <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-919-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-919-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Allow sensors to be
 aggregated us...
Content-Type: text/plain
Message-Id: <20151005135728.8983EE0441@git1-us-west.apache.org>
Date: Mon,  5 Oct 2015 13:57:28 +0000 (UTC)

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/919#discussion_r41145950
  
    --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/Enrichers.java ---
    @@ -171,6 +173,9 @@ public PropagatorBuilder propagatingAllBut(Iterable<? extends Sensor<?>> vals) {
             public JoinerBuilder joining(AttributeSensor<?> source) {
                 return new JoinerBuilder(source);
             }
    +        public <S, T> ReducerBuilder<S, T> reducing(Class<? extends Reducer<S, T>> clazz, List<AttributeSensor<S>> sourceSensors) {
    --- End diff --
    
    Would be nice to have an additional method factory which just uses the generic `Reducer` implementation, working with `Function<List<?>, ?>` params - which I guess would be the main way it's used in java land.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---