brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hadrian Zbarcea <hzbar...@gmail.com>
Subject Re: [PROPOSAL] Split brooklyn-core during OSGification
Date Mon, 12 Oct 2015 18:48:15 GMT
Yes and yes.
Hadrian

On 10/12/2015 12:12 PM, Alex Heneveld wrote:
>
> Will we still be able to run testng tests w/o osgi?  Or can osgi load
> times be kept very very low?
>
> Currently many unit tests don't configure osgi because it is the
> difference between a test taking <1s to run and >10s to run.  To
> encourage test-driven dev I'd like to keep that low round-trip time.
>
> --A
>
>
> On 12/10/2015 17:40, Ciprian Ciubotariu wrote:
>> Oh, I see.
>>
>> The pax-exam runner has a testng driver, which means that the general
>> aspect
>> of tests will remain the same. However, pax-exam will start/stop the osgi
>> framework before running tests and inject various needed services into
>> the
>> test class. One such service might be the framework itself.
>>
>> Cipi
>>
>> On Monday 12 October 2015 16:31:22 Aled Sage wrote:
>>> Thanks Ciprian,
>>>
>>> Yes, I think that answers my question.
>>>
>>> I assumed you would say pax-exam runner :-) I'm not familiar enough with
>>> it to picture what the tests would look like and how it would change the
>>> way we run our tests (both in the IDE and from jenkins), but that
>>> doesn't need described/addressed right now.
>>>
>>> Aled
>>>
>>> On 12/10/2015 16:25, Ciprian Ciubotariu wrote:
>>>> On Monday 12 October 2015 15:35:24 Aled Sage wrote:
>>>>> +1; sounds sensible.
>>>>>
>>>>> Would brooklyn-core have a dependency on brooklyn-rt-felix?
>>>> Yes, during build time and with the current launcher(s). However, the
>>>> brooklyn-core OSGi bundle won't import the packages of
>>>> brooklyn-rt-felix,
>>>> and the osgi container services will be used instead.
>>>>
>>>>> Presumably the unit tests in core would continue to run outside of
>>>>> Karaf
>>>>> (e.g.
>>>>> org.apache.brooklyn.core.mgmt.osgi.OsgiVersionMoreEntityTest)? How
>>>>> would you imagine those tests be run/rewritten once the
>>>>> OSGi'fication is
>>>>> complete?
>>>> At the moment they will continue to be executed by the testng
>>>> runner, but
>>>> they would be migrated to the pax-exam runner. Was this the target of
>>>> your question?
>>>>
>>>>> Aled
>>>>>
>>>>> On 12/10/2015 14:53, Ciprian Ciubotariu wrote:
>>>>>> While working on running Brooklyn inside Karaf I ran into the code
>>>>>> that
>>>>>> manages an embedded Apache Felix runtime.
>>>>>>
>>>>>> Since the roles are now reversed, I propose to split brooklyn-core
>>>>>> into
>>>>>> the
>>>>>> following:
>>>>>>
>>>>>> * brooklyn-core - new implementation using the Karaf-provided OSGi
>>>>>> runtime
>>>>>> * brooklyn-rt-felix - existing code using felix as an embedded OSGI
>>>>>> runtime
>>>>>> (which will no longer be needed when OSGification is complete)
>>>>>>
>>>>>> This change is much needed since the Apache Felix packages that
>>>>>> are used
>>>>>> to
>>>>>> start and stop the embedded framework are private within the felix
>>>>>> bundle
>>>>>>
>>>>>> My intention is to move current code to brooklyn-rt-felix, and
>>>>>> defer to
>>>>>> it
>>>>>> when the Karaf container is not present, while using the
>>>>>> Karaf-provided
>>>>>> felix/equinox framework by default.
>>>>>>
>>>>>> I have already started to code in that direction, but since this
is a
>>>>>> larger change I would like to hear your thoughts on the matter.
>
>

Mime
View raw message