brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From azbarcea <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: [BROOKLYN-166] add codemirror, ya...
Date Thu, 29 Oct 2015 23:31:59 GMT
Github user azbarcea commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/865#discussion_r43457600
  
    --- Diff: usage/rest-server/src/test/java/org/apache/brooklyn/rest/BrooklynRestApiLauncher.java
---
    @@ -314,6 +314,7 @@ public static void main(String[] args) throws Exception {
         public static Server startRestResourcesViaFilter() {
             return new BrooklynRestApiLauncher()
                     .mode(StartMode.FILTER)
    +                .forceUseOfDefaultCatalogWithJavaClassPath(true)
    --- End diff --
    
    Well this is the only way I know to see something in the catalog and test brooklyn.  `$
bin\brooklyn launch` uses `.forceUseOfDefaultCatalogWithJavaClassPath(true)`. Don't you want
the test to be identical with the way is used? I think it slows down the build (the tests),
but has no other consequence.
    
    Do you have any suggestions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message