brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Update Tomcat's webapp.url sensor...
Date Tue, 27 Oct 2015 16:36:29 GMT
Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/959#issuecomment-151561676
  
    Don't fully agree @ahgittin, `main.uri` should be the externally accessible URL, where
sensors will poll for values, will be given to users to connect to. Whether you need an external
or internal url *between* entities is known at composition time only. If doing it in yaml
you'll want to override the default sensor. Java group entities usually assume local network
and directly use the subnet sensor (see [this](https://github.com/apache/incubator-brooklyn/blob/master/software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/riak/RiakClusterImpl.java#L231-L232)
for example).
    
    So until we have a principled way to handle this I'd say keep the public IP.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message