brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Introduce relationships between b...
Date Tue, 27 Oct 2015 14:32:30 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/987#discussion_r43128732
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/objs/AbstractBrooklynObject.java
---
    @@ -55,8 +57,18 @@
         @SetFromFlag(value = "tags")
         private final Set<Object> tags = Sets.newLinkedHashSet();
     
    +    private RelationSupportInternal<PublicSelfType> relations = new ByObjectBasicRelationSupport<PublicSelfType>(getPublicThis(),
new RelationChangedCallback());
    --- End diff --
    
    Went to investigate a bit deeper as it didn't seem right. The constructor of `BrooklynObject`s
is called because we are asking Brooklyn to instantiate the object. But for plain java objects
which happen to be config/sensor values xstream handles instantiation and it won't call any
of the constructors.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message