brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Brooklyn OSGification - step 1 (b...
Date Tue, 27 Oct 2015 09:11:35 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/962#discussion_r43097079
  
    --- Diff: core/src/main/java/org/apache/brooklyn/util/core/osgi/Osgis.java ---
    @@ -90,46 +69,8 @@
         private static final Logger LOG = LoggerFactory.getLogger(Osgis.class);
     
         private static final String EXTENSION_PROTOCOL = "system";
    -    private static final String MANIFEST_PATH = "META-INF/MANIFEST.MF";
         private static final Set<String> SYSTEM_BUNDLES = MutableSet.of();
     
    -    public static class VersionedName {
    --- End diff --
    
    violates deprecation policy -- mark as `/** @deprecated since 0.9.0, replaced with top-level
class */`.  this impl could extend the top-level class.  that will ensure code using this
does not break.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message