brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Brooklyn OSGification - step 1 (b...
Date Tue, 27 Oct 2015 09:08:37 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/962#discussion_r43096817
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/persist/XmlMementoSerializer.java
---
    @@ -345,7 +345,36 @@ public Object unmarshal(HierarchicalStreamReader reader, UnmarshallingContext
co
                 }
             }
         }
    -    
    +
    +    // TODO: readClassType() and readClassAttribute()
    +    // Temporarily copied until osgification is finished from bundle-private class
    +    //   com.thoughtworks.xstream.core.util.HierarchicalStreams
    +    // Perhaps context.getRequiredType(); can be used instead?
    +    // Other users of xstream (e.g. jenkinsci) manually check for resoved-to and class
attributes
    +    //   for compatibility with older versions of xstream
    +    public static Class readClassType(HierarchicalStreamReader reader, Mapper mapper)
{
    --- End diff --
    
    should this and next method be `private static`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message