brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Introduce relationships between b...
Date Fri, 23 Oct 2015 16:03:37 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42882539
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogItemDo.java
---
    @@ -65,6 +64,19 @@ public SubscriptionSupportInternal subscriptions() {
             throw new UnsupportedOperationException();
         }
         
    +    /**
    +     * @throws UnsupportedOperationException; relations are not supported for catalog
items
    +     */
    +    @Override
    +    public RelationSupportInternal<CatalogItem<T,SpecT>> relations() {
    +        throw new UnsupportedOperationException();
    --- End diff --
    
    I think it's better to return an immutable empty RelationSupport object instead. This
will allow to avoid special casing `CatalogItem` when working with `BrooklynObject`s.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message