brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Introduce relationships between b...
Date Fri, 23 Oct 2015 15:59:58 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42882151
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/mgmt/rebind/mementos/Memento.java
---
    @@ -77,7 +79,8 @@
     
         public Collection<Object> getTags();
         
    +    Map<String, Set<BrooklynObject>> getRelations();
    --- End diff --
    
    I'm surprised to see `BrooklynObject` reference in the memento, the existing practice
is to store the IDs only. Not much of a difference in the end though since xstream will take
care of it. May be we should do the same for the other references as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message