brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Introduce relationships between b...
Date Fri, 23 Oct 2015 14:47:47 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/987#discussion_r42873240
  
    --- Diff: api/src/main/java/org/apache/brooklyn/api/objs/Configurable.java ---
    @@ -41,6 +41,11 @@
         @Deprecated
         public <T> T setConfig(ConfigKey<T> key, T val);
     
    +    /**
    +     * Convenience method for {@code config().get(key)}
    +     */
    +    <T> T getConfig(ConfigKey<T> key);
    --- End diff --
    
    `config().get()` is not much longer, so this is of questionable value. But if we have
it, better have the mirroring method as well - remove `@Deprecated` from the `setConfig`.
    
    Personally I prefer to have one true way to do things (in general, not only here).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message