brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hzbarcea <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Move winrm base from brooklyn-cor...
Date Thu, 15 Oct 2015 16:00:46 GMT
Github user hzbarcea commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/957#discussion_r42143587
  
    --- Diff: software/winrm/pom.xml ---
    @@ -0,0 +1,65 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    --- End diff --
    
    @bostko This was discussed on the mailing list on the Subject: "[PROPOSAL] Split brooklyn-core
during OSGification" thread. The ./software/winrm location was suggested by @ahgittin and
it's a tad less than ideal, because software/based now depends on software/winrm, but it's
good enough.
    
    This change is good regardless because it allows splitting the brooklyn-core into services
that are optional (like support for winrm in this case), making it more modular and more manageable,
but it's important because the current implementation is blocking the effort to fully OSGi-ify
brooklyn, dragging in jython via winrm4j. You are right that a rewrite of winrm4j should be
OSGi compliant, but that still leaves the issue of the brooklyn 'glue' which should still
be a separate component.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message