brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Camp parsing cleanup and fixes
Date Thu, 15 Oct 2015 13:37:05 GMT
Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/955#issuecomment-148388761
  
    A lot of the logic in `org.apache.brooklyn.camp.brooklyn.spi.creation.BrooklynComponentTemplateResolver.configureEntityConfig(EntitySpec<?>)`
seems to be generic, not specific to CAMP. Probably makes sense to let the resolvers do the
configuration, passing them the attributes/properties. This will require changing the interface
once again, so better do it sooner rather than later, but better not wait and merge this PR
as is, already has more than enough changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message