brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: [BROOKLYN-166] add codemirror, ya...
Date Thu, 08 Oct 2015 15:05:09 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/865#issuecomment-146573248
  
    also note that the catalog yaml syntax is different, as described at https://brooklyn.incubator.apache.org/v/latest/ops/catalog/index.html
.  it allows you to paste a simple blueprint or several such.  not a blocker for this but
important when completion is enabled; maybe for now a quick win would be to have a sample
template with the right syntax, or comments showing the right syntax.
    
    i confirm `bin/brooklyn launch` works nicely.  and switching between tabs in the "add
application" wizard causes no problems (but it isn't using the new codemirror any more.)
    
    newly found issues:
    
    * check/fix `overflow-x: scroll` for other textareas
    
    * add license info for codemirror in `overrides.yaml`
    
    * the JS console gives an error trying to load `/assets/css/complete.css`
    
    others still outstanding:
    
    * if possible, put 3rd party deps into `libs/` like the others, but if that's too hard
leave as is
    
    * the rat check needs to scan all files or have an explanation.  if it's really really
hard to have the codemirror files live under `libs/` then call them out explicitly here with
a comment explaining why they have the unusual structure
    
    * update the two `TODO` comments, or expand on who/when they'll get done
    
    if we could add this to the wizard -- or completely rewrite the wizard as part of drag-and-drop
-- then that would be good, but not needed in this PR.
    
    i think very soon we should start on a new UI based on angular.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message