brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: [BROOKLYN-166] add codemirror, ya...
Date Thu, 08 Oct 2015 14:50:32 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/865#discussion_r41522774
  
    --- Diff: usage/jsgui/src/main/webapp/assets/css/brooklyn.css ---
    @@ -25,7 +25,6 @@ BODY {
     textarea {
         white-space: pre;
         word-wrap: normal;
    -    overflow-x: scroll;
    --- End diff --
    
    i think we rely on textareas scrolling e.g. when we show a blueprint or other formatted
code in a textarea.
    
    it perhaps would be better to have a special style for this but if we're removing this
style have you made sure that no textareas suffer bad consequences?  if needed either update
them or if you need a different `overflow-x` behaviour in the codemirror views define a new
css rule.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message