brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: [BROOKLYN-166] add codemirror, ya...
Date Mon, 05 Oct 2015 10:31:42 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/865#discussion_r41129553
  
    --- Diff: usage/jsgui/src/main/webapp/assets/js/view/application-add-wizard.js ---
    @@ -180,14 +183,13 @@ define([
                 }
                 
                 // finish from config step, preview step, and from first step if yaml tab
selected (and valid)
    -            var finishVisible = (this.currentStep >= 1)
    -            var finishEnabled = finishVisible
    +            var finishVisible = (this.currentStep >= 1);
    +            var finishEnabled = finishVisible;
                 if (!finishEnabled && this.currentStep==0) {
                     if (this.model.mode == "yaml") {
                         // should do better validation than non-empty
                         finishVisible = true;
    -                    var yaml_code = this.$("#yaml_code").val()
    -                    if (yaml_code) {
    +                    if (self.editor && self.editor && self.editor.getValue())
{
    --- End diff --
    
    Second `self.editor` is not necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message