Return-Path: 
 <dev-return-10377-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2ACF618E8F
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Mon, 21 Sep 2015 17:43:46 +0000 (UTC)
Received: (qmail 84736 invoked by uid 500); 21 Sep 2015 17:43:46 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 84703 invoked by uid 500); 21 Sep 2015 17:43:46 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 84692 invoked by uid 99); 21 Sep 2015 17:43:45 -0000
Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Sep 2015 17:43:45 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org)
 with ESMTP id 62A51180293
	for <dev@brooklyn.apache.org>; Mon, 21 Sep 2015 17:43:45 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.975
X-Spam-Level: 
X-Spam-Status: No, score=0.975 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.006, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-eu-west.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new,
 port 10024)
	with ESMTP id 0zk1jk2cK7lp for <dev@brooklyn.apache.org>;
	Mon, 21 Sep 2015 17:43:39 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with
 SMTP id 8238720382
	for <dev@brooklyn.incubator.apache.org>;
 Mon, 21 Sep 2015 17:43:38 +0000 (UTC)
Received: (qmail 81976 invoked by uid 99); 21 Sep 2015 17:43:34 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Sep 2015 17:43:34 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 75417E0440; Mon, 21 Sep 2015 17:43:34 +0000 (UTC)
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-910-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-910-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Regex replacement dsl
Content-Type: text/plain
Message-Id: <20150921174334.75417E0440@git1-us-west.apache.org>
Date: Mon, 21 Sep 2015 17:43:34 +0000 (UTC)

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/910#discussion_r40001198
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/sensor/DependentConfiguration.java ---
    @@ -483,6 +483,114 @@ public T apply(@Nullable U input) {
                 taskArgs);
         }
     
    +    public static Task<String> regexReplacement(Object source, Object pattern, Object replacement) {
    +        List<TaskAdaptable<Object>> taskArgs = getTaskAdaptable(source, pattern, replacement);
    +        Function<List<Object>, String> transformer = new RegexTransformerString(source, pattern, replacement);
    +        return transformMultiple(
    +                MutableMap.of("displayName", String.format("creating regex replacement function (%s:%s)", pattern, replacement)),
    +                transformer,
    +                taskArgs
    +        );
    +    }
    +
    +    public static Task<Function<String, String>> regexReplacement(Object pattern, Object replacement) {
    +        List<TaskAdaptable<Object>> taskArgs = getTaskAdaptable(pattern, replacement);
    +        Function<List<Object>, Function<String, String>> transformer = new RegexTransformerFunction(pattern, replacement);
    +        return transformMultiple(
    +                MutableMap.of("displayName", String.format("creating regex replacement function (%s:%s)", pattern, replacement)),
    +                transformer,
    +                taskArgs
    +        );
    +    }
    +
    +    private static List<TaskAdaptable<Object>> getTaskAdaptable(Object... args){
    +        List<TaskAdaptable<Object>> taskArgs = Lists.newArrayList();
    +        for (Object arg: args) {
    +            if (arg instanceof TaskAdaptable) {
    +                taskArgs.add((TaskAdaptable<Object>)arg);
    +            } else if (arg instanceof TaskFactory) {
    +                taskArgs.add(((TaskFactory<TaskAdaptable<Object>>)arg).newTask());
    +            }
    +        }
    +        return taskArgs;
    +    }
    +
    +    public static class RegexTransformerString implements Function<List<Object>, String> {
    +
    +        private final Object source;
    +        private final Object pattern;
    +        private final Object replacement;
    +
    +        public RegexTransformerString(Object source, Object pattern, Object replacement){
    +            this.source = source;
    +            this.pattern = pattern;
    +            this.replacement = replacement;
    +        }
    +
    +        @Nullable
    +        @Override
    +        public String apply(@Nullable List<Object> input) {
    +            Iterator<?> taskArgsIterator = input.iterator();
    +            String resolvedSource = resolveArgument(source, taskArgsIterator);
    +            String resolvedPattern = resolveArgument(pattern, taskArgsIterator);
    +            String resolvedReplacement = resolveArgument(replacement, taskArgsIterator);
    +            return new RegexReplacer(resolvedPattern, resolvedReplacement).apply(resolvedSource);
    +        }
    +    }
    +
    +    public static class RegexTransformerFunction implements Function<List<Object>, Function<String, String>> {
    +
    +        private final Object pattern;
    +        private final Object replacement;
    +
    +        public RegexTransformerFunction(Object pattern, Object replacement){
    +            this.pattern = pattern;
    +            this.replacement = replacement;
    +        }
    +
    +        @Override
    +        public Function<String, String> apply(List<Object> input) {
    +            Iterator<?> taskArgsIterator = input.iterator();
    +            return new RegexReplacer(resolveArgument(pattern, taskArgsIterator), resolveArgument(replacement, taskArgsIterator));
    +        }
    +
    +    }
    +
    +    /**
    +     * Resolves the argument as follows:
    +     *
    +     * If the argument is a DeferredSupplier, we will block and wait for it to resolve. If the argument is TaskAdaptable or TaskFactory,
    +     * we will assume that the resolved task has been queued on the {@code taskArgsIterator}, otherwise the argument has already been resolved.
    +     */
    +    private static String resolveArgument(Object argument, Iterator<?> taskArgsIterator) {
    +        Object resolvedArgument;
    +        if (argument instanceof TaskAdaptable) {
    +            resolvedArgument = taskArgsIterator.next();
    +        } else if (argument instanceof DeferredSupplier) {
    +            resolvedArgument = ((DeferredSupplier<?>) argument).get();
    +        } else {
    +            resolvedArgument = argument;
    +        }
    +        return String.valueOf(resolvedArgument);
    +    }
    +
    +    public static class RegexReplacer implements Function<String, String> {
    --- End diff --
    
    move to `StringFunctions` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---