Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-906-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-906-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Capture exit code in
 AbstractSoft...
Content-Type: text/plain
Message-Id: <20150918093933.1ADB3E00AC@git1-us-west.apache.org>
Date: Fri, 18 Sep 2015 09:39:33 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/906#discussion_r39838816
  
    --- Diff: software/base/src/test/java/org/apache/brooklyn/entity/software/base/lifecycle/ScriptHelperUnitTest.java ---
    @@ -0,0 +1,63 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.brooklyn.entity.software.base.lifecycle;
    +
    +import org.apache.brooklyn.entity.software.base.DoNothingSoftwareProcessDriver;
    +import org.apache.brooklyn.test.Asserts;
    +import org.testng.annotations.Test;
    +
    +import java.util.List;
    +import java.util.Map;
    +
    +import static org.mockito.Mockito.any;
    +import static org.mockito.Mockito.mock;
    +import static org.mockito.Mockito.when;
    +
    +public class ScriptHelperUnitTest {
    +    private static final String NON_ZERO_CODE_COMMAND = "false";
    +
    +    @Test
    +    public void testZeroExitCode() {
    +        DoNothingSoftwareProcessDriver sshRunner = mock(DoNothingSoftwareProcessDriver.class);
    +
    +        ScriptHelper scriptHelper = new ScriptHelper(sshRunner, "test-zero-code-task");
    +        Asserts.assertTrue(scriptHelper.executeInternal() == 0, "ScriptHelper doesn't return zero code");
    --- End diff --
    
    Better to use `Asserts.assetEquals(scriptHelper.executeInternal(), 0)`. With your code, the error won't tell us what the actual exit code is, which hides information.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---