Return-Path: 
 <dev-return-10274-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 18BB31738F
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Fri, 18 Sep 2015 09:30:45 +0000 (UTC)
Received: (qmail 19526 invoked by uid 500); 18 Sep 2015 09:30:45 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 19494 invoked by uid 500); 18 Sep 2015 09:30:45 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 19482 invoked by uid 99); 18 Sep 2015 09:30:44 -0000
Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Sep 2015 09:30:44 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org)
 with ESMTP id 53E63E083B
	for <dev@brooklyn.apache.org>; Fri, 18 Sep 2015 09:30:44 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.971
X-Spam-Level: 
X-Spam-Status: No, score=0.971 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01,
	RCVD_IN_MSPIKE_WL=-0.01, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-us-east.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new,
 port 10024)
	with ESMTP id z3MFJ-use9S7 for <dev@brooklyn.apache.org>;
	Fri, 18 Sep 2015 09:30:36 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with
 SMTP id 238E842B9A
	for <dev@brooklyn.incubator.apache.org>;
 Fri, 18 Sep 2015 09:30:36 +0000 (UTC)
Received: (qmail 19432 invoked by uid 99); 18 Sep 2015 09:30:35 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Sep 2015 09:30:35 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 897E9E0582; Fri, 18 Sep 2015 09:30:35 +0000 (UTC)
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-906-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-906-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Capture exit code in
 AbstractSoft...
Content-Type: text/plain
Message-Id: <20150918093035.897E9E0582@git1-us-west.apache.org>
Date: Fri, 18 Sep 2015 09:30:35 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/906#discussion_r39838215
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessWinRmDriver.java ---
    @@ -154,11 +214,11 @@ protected WinRmToolResponse executeCommand(ConfigKey<String> regularCommandKey,
             Task<?> currentTask = Tasks.current();
             if (currentTask != null) {
                 writeToStream(stdIn, Strings.isBlank(regularCommand) ? powershellCommand : regularCommand);
    -            Tasks.addTagDynamically(BrooklynTaskTags.tagForStreamSoft(BrooklynTaskTags.STREAM_STDIN, stdIn));
    +            Tasks.addTagDynamically(BrooklynTaskTags.tagForStreamSoft(BrooklynTaskTags.STREAM_STDIN, stdIn)); flags.put("stdin", stdIn);
     
                 if (BrooklynTaskTags.stream(currentTask, BrooklynTaskTags.STREAM_STDOUT)==null) {
    -                Tasks.addTagDynamically(BrooklynTaskTags.tagForStreamSoft(BrooklynTaskTags.STREAM_STDOUT, stdOut));
    -                Tasks.addTagDynamically(BrooklynTaskTags.tagForStreamSoft(BrooklynTaskTags.STREAM_STDERR, stdErr));
    +                Tasks.addTagDynamically(BrooklynTaskTags.tagForStreamSoft(BrooklynTaskTags.STREAM_STDOUT, stdOut)); flags.put("stdout", stdOut);
    --- End diff --
    
    Can you separate these commands onto multiple lines - it risks being missed by someone reading the code when at the end of a long line like this. Same for the code above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---